qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/smbios: Add table 4 parameter, "processor-id"


From: Patrick Venture
Subject: Re: [PATCH] hw/smbios: Add table 4 parameter, "processor-id"
Date: Mon, 24 Jan 2022 11:52:18 -0800



On Tue, Jan 18, 2022 at 11:37 PM Igor Mammedov <imammedo@redhat.com> wrote:
On Tue, 18 Jan 2022 09:15:42 -0800
Patrick Venture <venture@google.com> wrote:

> On Tue, Jan 11, 2022 at 5:13 AM Igor Mammedov <imammedo@redhat.com> wrote:
>
> > On Thu,  6 Jan 2022 14:33:16 -0800
> > Patrick Venture <venture@google.com> wrote:
> > 
[...]
> > > diff --git a/qemu-options.hx b/qemu-options.hx
> > > index ec90505d84..3c51b6cf8f 100644
> > > --- a/qemu-options.hx
> > > +++ b/qemu-options.hx
> > > @@ -2527,6 +2527,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios,
> > >      "                specify SMBIOS type 3 fields\n"
> > >      "-smbios 
> > type=4[,sock_pfx=str][,manufacturer=str][,version=str][,serial=str]\n" 
> > >      " 
> > [,asset=str][,part=str][,max-speed=%d][,current-speed=%d]\n" 
> > > +    "              [,processor-id=%d]\n"
> > >      "                specify SMBIOS type 4 fields\n"
> > >      "-smbios type=11[,value=str][,path=filename]\n"
> > >      "                specify SMBIOS type 11 fields\n" 
> >
> > missing update of SRST part
> > 
>
> I grepped for SRST, where is this that I need to update also?

option definition has 2 parts DEF() and SRST that follows right
after it, the later is used as help text for the option
SRST                                               

Ahh, yeah, I grepped in the wrong place :)

Working on validating v2 presently then sending out.
 
                             
``-smbios file=binary``
...

>
> Thanks!

Thanks! 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]