On Tue, Jan 25, 2022 at 08:44:30AM +0100, Gerd Hoffmann wrote:
On Mon, Jan 24, 2022 at 06:09:12PM +0100, BALATON Zoltan wrote:
On Sun, 16 Jan 2022, BALATON Zoltan wrote:
Hello,
I have these patches from last October when we've looked at what
causes problems with mac99 and USB. We've found the main problem is
likely not allowing pending packets per endpoint which we did not fix
but these patches came out of debugging that and trying to improve the
device model so eventually the real problem could be fixed more
easily. So these are just clean ups and fixing one potential issue
with isochronous transfers breaking pending async packet but it does
not solve all problems OHCI currently has. I'm sending it anyway as I
don't plan to work further on this so this series could be taken as is
for now.
Ping?
Queued now.
Oops, have to take that back, checkpatch throws errors:
HEAD is now at 00abd6f54a24 usb/ohci: Don't use packet from OHCIState for
isochronous transfers
error: no note found for object 00abd6f54a246db5877ceb466755374b297d97cf.
ERROR: braces {} are necessary for all arms of this statement
#131: FILE: hw/usb/hcd-ohci.c:1115:
+ if (ohci_service_iso_td(ohci, &ed))
[...]
total: 1 errors, 0 warnings, 153 lines checked
Please check all patches & resend.