[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/9pfs: fix mkdir() being called twice
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH] tests/9pfs: fix mkdir() being called twice |
|
Date: |
Tue, 25 Jan 2022 15:12:00 +0000 |
|
User-agent: |
Mutt/2.1.3 (2021-09-10) |
On Sat, Jan 22, 2022 at 08:12:16PM +0100, Christian Schoenebeck wrote:
> The 9p test cases use mkdtemp() to create a temporary directory for
> running the 'local' 9p tests with real files/dirs. Unlike mktemp()
> which only generates a unique file name, mkdtemp() also creates the
> directory, therefore the subsequent mkdir() was wrong and caused
> errors on some systems.
>
> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> Fixes: 136b7af2 (tests/9pfs: fix test dir for parallel tests)
> Reported-by: Daniel P. Berrangé <berrange@redhat.com>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/832
> ---
> tests/qtest/libqos/virtio-9p.c | 18 +++---------------
> 1 file changed, 3 insertions(+), 15 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|