qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/1] migration: Remove unused minimum_version_id_old and load_sta


From: Juan Quintela
Subject: [PATCH 1/1] migration: Remove unused minimum_version_id_old and load_state_old
Date: Tue, 25 Jan 2022 18:07:16 +0100

They were already deprecated and after ppc removal no users on the
tree. RIP.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 docs/devel/migration.rst    | 7 +------
 include/migration/vmstate.h | 2 --
 migration/vmstate.c         | 6 ------
 3 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
index 2401253482..98c5e4a13f 100644
--- a/docs/devel/migration.rst
+++ b/docs/devel/migration.rst
@@ -394,14 +394,9 @@ You can see that there are several version fields:
 - ``version_id``: the maximum version_id supported by VMState for that device.
 - ``minimum_version_id``: the minimum version_id that VMState is able to 
understand
   for that device.
-- ``minimum_version_id_old``: For devices that were not able to port to 
vmstate, we can
-  assign a function that knows how to read this old state. This field is
-  ignored if there is no ``load_state_old`` handler.
 
 VMState is able to read versions from minimum_version_id to
-version_id.  And the function ``load_state_old()`` (if present) is able to
-load state from minimum_version_id_old to minimum_version_id.  This
-function is deprecated and will be removed when no more users are left.
+version_id.
 
 There are *_V* forms of many ``VMSTATE_`` macros to load fields for version 
dependent fields,
 e.g.
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 017c03675c..ad24aa1934 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -181,9 +181,7 @@ struct VMStateDescription {
     int unmigratable;
     int version_id;
     int minimum_version_id;
-    int minimum_version_id_old;
     MigrationPriority priority;
-    LoadStateHandler *load_state_old;
     int (*pre_load)(void *opaque);
     int (*post_load)(void *opaque, int version_id);
     int (*pre_save)(void *opaque);
diff --git a/migration/vmstate.c b/migration/vmstate.c
index 05f87cdddc..36ae8b9e19 100644
--- a/migration/vmstate.c
+++ b/migration/vmstate.c
@@ -90,12 +90,6 @@ int vmstate_load_state(QEMUFile *f, const VMStateDescription 
*vmsd,
         return -EINVAL;
     }
     if  (version_id < vmsd->minimum_version_id) {
-        if (vmsd->load_state_old &&
-            version_id >= vmsd->minimum_version_id_old) {
-            ret = vmsd->load_state_old(f, opaque, version_id);
-            trace_vmstate_load_state_end(vmsd->name, "old path", ret);
-            return ret;
-        }
         error_report("%s: incoming version_id %d is too old "
                      "for local minimum version_id  %d",
                      vmsd->name, version_id, vmsd->minimum_version_id);
-- 
2.34.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]