[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 7/7] qapi: generate trace events by default
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v5 7/7] qapi: generate trace events by default |
Date: |
Wed, 26 Jan 2022 15:04:37 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> We don't generate trace events for tests/ and qga/ because that it is
> not simple and not necessary. We have corresponding comments in both
> tests/meson.build and qga/meson.build.
>
> Still to not miss possible future qapi code generation call, and not to
> forget to enable trace events generation, let's enable it by default.
> So, turn option --gen-trace into opposite --no-trace-events and use new
Let's call it --suppress-tracing.
> option only in tests/ and qga/ where we already have good comments why
> we don't generate trace events code.
>
> Note that this commit enables trace-events generation for qapi-gen.py
> call from tests/qapi-schema/meson.build and storage-daemon/meson.build.
> Still, both are kind of noop: tests/qapi-schema/ doesn't seem to
> generate any QMP command code and no .trace-events files anyway,
> storage-daemon/ uses common QMP command implementations and just
> generate empty .trace-events
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
- Re: [PATCH v5 6/7] meson: document, why we don't generate trace events for tests/ and qga/, (continued)
- [PATCH v5 1/7] scripts/qapi/gen.py: add FOO.trace-events output module, Vladimir Sementsov-Ogievskiy, 2022/01/25
- [PATCH v5 5/7] docs/qapi-code-gen: update to cover trace events code generation, Vladimir Sementsov-Ogievskiy, 2022/01/25
- [PATCH v5 7/7] qapi: generate trace events by default, Vladimir Sementsov-Ogievskiy, 2022/01/25
- Re: [PATCH v5 7/7] qapi: generate trace events by default,
Markus Armbruster <=
- [PATCH v5 2/7] qapi/commands: refactor error handling code, Vladimir Sementsov-Ogievskiy, 2022/01/25
- [PATCH v5 3/7] qapi/commands: Optionally generate trace for QMP commands, Vladimir Sementsov-Ogievskiy, 2022/01/25
- [PATCH v5 4/7] meson: generate trace events for qmp commands, Vladimir Sementsov-Ogievskiy, 2022/01/25
- Re: [PATCH v5 0/7] trace qmp commands, Stefan Hajnoczi, 2022/01/26
- Re: [PATCH v5 0/7] trace qmp commands, Markus Armbruster, 2022/01/26