[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-7.0] rtc: Move RTC function prototypes to their own heade
From: |
Peter Maydell |
Subject: |
Re: [PATCH for-7.0] rtc: Move RTC function prototypes to their own header |
Date: |
Thu, 27 Jan 2022 16:34:56 +0000 |
On Mon, 29 Nov 2021 at 20:55, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> softmmu/rtc.c defines two public functions: qemu_get_timedate() and
> qemu_timedate_diff(). Currently we keep the prototypes for these in
> qemu-common.h, but most files don't need them. Move them to their
> own header, a new include/sysemu/rtc.h.
>
> Since the C files using these two functions did not need to include
> qemu-common.h for any other reason, we can remove those include lines
> when we add the include of the new rtc.h.
>
> The license for the .h file follows that of the softmmu/rtc.c
> where both the functions are defined.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I have added documentation comments for the two functions, but
> since my understanding of them and their purpose is little shaky
> review would be welcome.
I forgot about this patch from November; since Philippe has reviewed
it I'll take it via target-arm.next.
thanks
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH for-7.0] rtc: Move RTC function prototypes to their own header,
Peter Maydell <=