Re: [PATCH 1/2] migration/rdma: Increase the backlog from 5 to 128

[Jinpu Wang]

On Tue, Feb 1, 2022 at 7:19 PM Pankaj Gupta <pankaj.gupta@ionos.com> wrote:
>
> > So it can handle more incoming requests.
> >
> > Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> > ---
> >  migration/rdma.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/migration/rdma.c b/migration/rdma.c
> > index c7c7a384875b..2e223170d06d 100644
> > --- a/migration/rdma.c
> > +++ b/migration/rdma.c
> > @@ -4238,7 +4238,7 @@ void rdma_start_incoming_migration(const char 
> > *host_port, Error **errp)
> >
> >      trace_rdma_start_incoming_migration_after_dest_init();
> >
> > -    ret = rdma_listen(rdma->listen_id, 5);
> > +    ret = rdma_listen(rdma->listen_id, 128);
>
> 128 backlog seems too much to me. Any reason for choosing this number.
> Any rationale to choose this number?
>
128 is the default value of SOMAXCONN, I can use that if it is preferred.

> Thanks,
> Pankaj

Thanks!
>
> >
> >      if (ret) {
> >          ERROR(errp, "listening on socket!");
> > --
> > 2.25.1
> >