Re: [PATCH v5 6/7] target/riscv: Add XVentanaCondOps custom extension

[Richard Henderson]

On 2/1/22 19:36, Philipp Tomsich wrote:
> > > +static bool gen_condmask(DisasContext *ctx, arg_r *a, TCGCond cond)
> >
> > This should also have a vendor prefix
>
> This one is a static helper function inside a file
> ..._xventanacondops..._ and not visible outside the compilation unit.
> Do we really want to prefix such functions that have local scope as well?

This file is included, therefore the compilation unit is larger than you think.


r~