Re: [PATCH] target/hexagon: remove unused variable

[Thomas Huth]

On 24/01/2022 07.43, Zongyuan Li wrote:
> When building with clang version 13.0.0 (eg. Fedora 13.0.0-3.fc35),
> two unused variables introduced by macro GATHER_FUNCTION and
> SCATTER_FUNCTION will cause building process failure due to
> [-Werror -Wunused-variable].
>
> Signed-off-by: Zongyuan Li <zongyuan.li@smartx.com>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/831
> ---
>   target/hexagon/mmvec/macros.h | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/target/hexagon/mmvec/macros.h b/target/hexagon/mmvec/macros.h
> index 10f4630364..44781cfb4a 100644
> --- a/target/hexagon/mmvec/macros.h
> +++ b/target/hexagon/mmvec/macros.h
> @@ -164,11 +164,9 @@
>           target_ulong va = EA; \
>           target_ulong va_high = EA + LEN; \
>           uintptr_t ra = GETPC(); \
> -        int log_bank = 0; \
>           int log_byte = 0; \
>           for (i0 = 0; i0 < ELEMENT_SIZE; i0++) { \
>               log_byte = ((va + i0) <= va_high) && QVAL; \
> -            log_bank |= (log_byte << i0); \
>               uint8_t B; \
>               B = cpu_ldub_data_ra(env, EA + i0, ra); \
>               env->tmp_VRegs[0].ub[ELEMENT_SIZE * IDX + i0] = B; \
> @@ -243,11 +241,9 @@
>           int i0; \
>           target_ulong va = EA; \
>           target_ulong va_high = EA + LEN; \
> -        int log_bank = 0; \
>           int log_byte = 0; \
>           for (i0 = 0; i0 < ELEM_SIZE; i0++) { \
>               log_byte = ((va + i0) <= va_high) && QVAL; \
> -            log_bank |= (log_byte << i0); \
>               LOG_VTCM_BYTE(va + i0, log_byte, IN.ub[ELEM_SIZE * IDX + i0], \
>                             ELEM_SIZE * IDX + i0); \
>           } \

Reviewed-by: Thomas Huth <thuth@redhat.com>