[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/7] tests/qtest: failover: use a macro for check_one_card()
From: |
Laurent Vivier |
Subject: |
[PATCH 2/7] tests/qtest: failover: use a macro for check_one_card() |
Date: |
Thu, 3 Feb 2022 15:15:32 +0100 |
This allows g_assert() to correctly report the line number of the error
in the test case.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
tests/qtest/virtio-net-failover.c | 47 ++++++++++++++-----------------
1 file changed, 21 insertions(+), 26 deletions(-)
diff --git a/tests/qtest/virtio-net-failover.c
b/tests/qtest/virtio-net-failover.c
index 207c1330125b..070e53de1292 100644
--- a/tests/qtest/virtio-net-failover.c
+++ b/tests/qtest/virtio-net-failover.c
@@ -224,32 +224,27 @@ static char *get_mac(QTestState *qts, const char *name)
return mac;
}
-static void check_one_card(QTestState *qts, bool present,
- const char *id, const char *mac)
-{
- QDict *device;
- QDict *bus;
- char *addr;
-
- bus = get_bus(qts, 0);
- device = find_device(bus, id);
- if (present) {
- char *path;
-
- g_assert_nonnull(device);
- qobject_unref(device);
-
- path = g_strdup_printf("/machine/peripheral/%s", id);
- addr = get_mac(qts, path);
- g_free(path);
- g_assert_cmpstr(mac, ==, addr);
- g_free(addr);
- } else {
- g_assert_null(device);
- }
-
- qobject_unref(bus);
-}
+#define check_one_card(qts, present, id, mac) \
+do { \
+ QDict *device; \
+ QDict *bus; \
+ char *addr; \
+ bus = get_bus(qts, 0); \
+ device = find_device(bus, id); \
+ if (present) { \
+ char *path; \
+ g_assert_nonnull(device); \
+ qobject_unref(device); \
+ path = g_strdup_printf("/machine/peripheral/%s", id); \
+ addr = get_mac(qts, path); \
+ g_free(path); \
+ g_assert_cmpstr(mac, ==, addr); \
+ g_free(addr); \
+ } else { \
+ g_assert_null(device); \
+ } \
+ qobject_unref(bus); \
+} while (0)
static void test_on(void)
{
--
2.34.1
- [PATCH 0/7] tests/qtest: add some tests for virtio-net failover (part 2), Laurent Vivier, 2022/02/03
- [PATCH 3/7] tests/qtest: failover: check the feature is correctly provided, Laurent Vivier, 2022/02/03
- [PATCH 1/7] tests/qtest: failover: clean up pathname of tests, Laurent Vivier, 2022/02/03
- [PATCH 4/7] tests/qtest: failover: check missing guest feature, Laurent Vivier, 2022/02/03
- [PATCH 7/7] tests/qtest: failover: migration abort test with failover off, Laurent Vivier, 2022/02/03
- [PATCH 5/7] tests/qtest: failover: check migration with failover off, Laurent Vivier, 2022/02/03
- [PATCH 2/7] tests/qtest: failover: use a macro for check_one_card(),
Laurent Vivier <=
- [PATCH 6/7] tests/qtest: failover: test migration if the guest doesn't support failover, Laurent Vivier, 2022/02/03
- Re: [PATCH 0/7] tests/qtest: add some tests for virtio-net failover (part 2), Laurent Vivier, 2022/02/15