[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 18/27] qga/vss-win32: fix midl arguments
From: |
Paolo Bonzini |
Subject: |
[PATCH 18/27] qga/vss-win32: fix midl arguments |
Date: |
Thu, 3 Feb 2022 18:33:50 +0100 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Microsoft midl compiler doesn't take "-options" form, nor does it take
OUTPUT filename. The -I option seems needless as well (at least with
VS15).
It's not clear what was actually used when it was introduced in commit
b39297aedfabe9.
strings says "Created by MIDL version 7.00.0555 at Fri Dec 21 13:36:39
2012".
I doubt the makefile rule actually ever worked.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
qga/vss-win32/meson.build | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build
index 90825edef3..78bdf5e74a 100644
--- a/qga/vss-win32/meson.build
+++ b/qga/vss-win32/meson.build
@@ -26,8 +26,7 @@ if midl.found()
gen_tlb = custom_target('gen-tlb',
input: 'qga-vss.idl',
output: 'qga-vss.tlb',
- command: [midl, '-tlb', '-I' +
config_host['WIN_SDK'],
- '@INPUT@', '@OUTPUT@'])
+ command: [midl, '@INPUT@', '/tlb', '@OUTPUT@'])
else
gen_tlb = custom_target('gen-tlb',
input: 'qga-vss.tlb',
--
2.34.1
- [PATCH 09/27] configure, meson: move image format options to meson_options.txt, (continued)
- [PATCH 09/27] configure, meson: move image format options to meson_options.txt, Paolo Bonzini, 2022/02/03
- [PATCH 13/27] configure, meson: move coroutine options to meson_options.txt, Paolo Bonzini, 2022/02/03
- [PATCH 10/27] configure, meson: move block layer options to meson_options.txt, Paolo Bonzini, 2022/02/03
- [PATCH 14/27] configure, meson: move smbd options to meson_options.txt, Paolo Bonzini, 2022/02/03
- [PATCH 12/27] configure, meson: move some default-disabled options to meson_options.txt, Paolo Bonzini, 2022/02/03
- [PATCH 15/27] configure, meson: move guest-agent, tools to meson, Paolo Bonzini, 2022/02/03
- [PATCH 26/27] meson, configure: move ntddscsi API check to meson, Paolo Bonzini, 2022/02/03
- [PATCH 27/27] configure, meson: move CONFIG_IASL to a Meson option, Paolo Bonzini, 2022/02/03
- [PATCH 18/27] qga/vss-win32: fix midl arguments,
Paolo Bonzini <=
- [PATCH 20/27] qga/vss-win32: use widl if available, Paolo Bonzini, 2022/02/03
- [PATCH 23/27] meson: do not make qga/vss-win32/meson.build conditional on C++ presence, Paolo Bonzini, 2022/02/03
- [PATCH 19/27] meson: drop --with-win-sdk, Paolo Bonzini, 2022/02/03
- [PATCH 21/27] qga/vss: use standard windows headers location, Paolo Bonzini, 2022/02/03