Re: [PATCH 2/4] tests/fp: Do not build softfloat3 tests if TCG is disabled

[Thomas Huth]

On 04/02/2022 16.29, Philippe Mathieu-Daudé wrote:
> Technically we don't need the TCG accelerator to run the
> softfloat3 tests. However it is unlikely an interesting
> build combination. Developers using softfloat3 likely use
> TCG too. Similarly, developers disabling TCG shouldn't
> mind much about softfloat3 tests.
>
> This reduces a non-TCG build by 474 objects!
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   tests/fp/meson.build | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/tests/fp/meson.build b/tests/fp/meson.build
> index 59776a00a7..60843fce85 100644
> --- a/tests/fp/meson.build
> +++ b/tests/fp/meson.build
> @@ -1,3 +1,6 @@
> +if 'CONFIG_TCG' not in config_all

Alternatively "if not config_all.has_key('CONFIG_TCG')" ? ... not sure which 
one is better, though

> +  subdir_done()
> +endif
>   # There are namespace pollution issues on Windows, due to osdep.h
>   # bringing in Windows headers that define a FLOAT128 type.
>   if targetos == 'windows'

Reviewed-by: Thomas Huth <thuth@redhat.com>