qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 4/5] tcg/sparc: Add tcg_out_jmpl_const for better tail cal


From: Peter Maydell
Subject: Re: [PATCH v4 4/5] tcg/sparc: Add tcg_out_jmpl_const for better tail calls
Date: Fri, 4 Feb 2022 18:34:17 +0000

On Fri, 4 Feb 2022 at 07:54, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Due to mapping changes, we now rarely place the code_gen_buffer
> near the main executable.  Which means that direct calls will
> now rarely be in range.
>
> So, always use indirect calls for tail calls, which allows us to
> avoid clobbering %o7, and therefore we need not save and restore it.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

As an aside: I found it a bit confusing that tcg_out_mov()
takes a 'type' argument but ignores it, whereas tcg_out_mov_delay()
doesn't take a 'type' argument at all.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]