qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 4/5] tcg/sparc: Add tcg_out_jmpl_const for better tail cal


From: Richard Henderson
Subject: Re: [PATCH v4 4/5] tcg/sparc: Add tcg_out_jmpl_const for better tail calls
Date: Sat, 5 Feb 2022 07:44:00 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 2/5/22 05:34, Peter Maydell wrote:
On Fri, 4 Feb 2022 at 07:54, Richard Henderson
<richard.henderson@linaro.org> wrote:

Due to mapping changes, we now rarely place the code_gen_buffer
near the main executable.  Which means that direct calls will
now rarely be in range.

So, always use indirect calls for tail calls, which allows us to
avoid clobbering %o7, and therefore we need not save and restore it.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

As an aside: I found it a bit confusing that tcg_out_mov()
takes a 'type' argument but ignores it, whereas tcg_out_mov_delay()
doesn't take a 'type' argument at all.

Mm. tcg_out_mov() is common to all tcg backends, and some hosts do use the type argument. I didn't add one to tcg_out_mov_delay() because sparc didn't need one.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]