qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 04/21] exec: Make cpu_memory_rw_debug() target agnostic


From: Richard Henderson
Subject: Re: [PATCH v2 04/21] exec: Make cpu_memory_rw_debug() target agnostic
Date: Sun, 6 Feb 2022 10:13:38 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 2/4/22 06:17, Philippe Mathieu-Daudé wrote:
cpu_memory_rw_debug() is declared in "exec/cpu-all.h" which
contains target-specific declarations. To be able to use it
from target agnostic source, move the declaration to the
generic "exec/cpu-common.h" header.

Replace the target-specific 'target_ulong' type by 'vaddr'
which better reflects the argument type, and is target agnostic.

Suggested-by: Richard Henderson<richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
  cpu.c                     | 6 +++---
  include/exec/cpu-all.h    | 4 ----
  include/exec/cpu-common.h | 4 ++++
  softmmu/cpus.c            | 2 +-
  softmmu/physmem.c         | 6 +++---
  5 files changed, 11 insertions(+), 11 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]