[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/8] linux-user: Remove unnecessary 'aligned' attribute from TaskS
From: |
Laurent Vivier |
Subject: |
[PULL 1/8] linux-user: Remove unnecessary 'aligned' attribute from TaskState |
Date: |
Mon, 7 Feb 2022 09:27:52 +0100 |
From: Peter Maydell <peter.maydell@linaro.org>
The linux-user struct TaskState has an 'aligned(16)' attribute. When
the struct was first added in commit 851e67a1b46f in 2003, there was
a justification in a comment (still present in the source today):
/* NOTE: we force a big alignment so that the stack stored after is
aligned too */
because the final field in the struct was "uint8_t stack[0];"
But that field was removed in commit 48e15fc2d in 2010 which
switched us to allocating the stack and the TaskState separately.
Because we allocate the structure with g_new0() rather than as
a local variable, the attribute made no difference to the alignment
of the structure anyway.
Remove the unnecessary attribute, and the corresponding comment.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20220114153732.3767229-2-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
linux-user/qemu.h | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 7910ce59cc8c..9d2b3119d1fe 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -94,10 +94,6 @@ struct emulated_sigtable {
target_siginfo_t info;
};
-/*
- * NOTE: we force a big alignment so that the stack stored after is
- * aligned too
- */
typedef struct TaskState {
pid_t ts_tid; /* tid (or pid) of this task */
#ifdef TARGET_ARM
@@ -158,7 +154,7 @@ typedef struct TaskState {
/* This thread's sigaltstack, if it has one */
struct target_sigaltstack sigaltstack_used;
-} __attribute__((aligned(16))) TaskState;
+} TaskState;
abi_long do_brk(abi_ulong new_brk);
--
2.34.1
- [PULL 0/8] Linux user for 7.0 patches, Laurent Vivier, 2022/02/07
- [PULL 5/8] linux-user: sigprocmask check read perms first, Laurent Vivier, 2022/02/07
- [PULL 2/8] linux-user/alpha: Fix target rlimits for alpha and rearrange for clarity, Laurent Vivier, 2022/02/07
- [PULL 4/8] linux-user: rt_sigprocmask, check read perms first, Laurent Vivier, 2022/02/07
- [PULL 6/8] linux-user: Implement starttime field in self stat emulation, Laurent Vivier, 2022/02/07
- [PULL 7/8] linux-user: Move generic TARGET_RLIMIT* definitions to generic/target_resource.h, Laurent Vivier, 2022/02/07
- [PULL 1/8] linux-user: Remove unnecessary 'aligned' attribute from TaskState,
Laurent Vivier <=
- [PULL 3/8] linux-user: Fix inotify on aarch64, Laurent Vivier, 2022/02/07
- [PULL 8/8] linux-user/syscall: Translate TARGET_RLIMIT_RTTIME, Laurent Vivier, 2022/02/07
- Re: [PULL 0/8] Linux user for 7.0 patches, Peter Maydell, 2022/02/07