[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 10/11] 9p: darwin: meson: Allow VirtFS on Darwin
From: |
Christian Schoenebeck |
Subject: |
Re: [PATCH v4 10/11] 9p: darwin: meson: Allow VirtFS on Darwin |
Date: |
Mon, 07 Feb 2022 15:27:45 +0100 |
On Sonntag, 6. Februar 2022 21:07:18 CET Will Cohen wrote:
> From: Keno Fischer <keno@juliacomputing.com>
>
> Signed-off-by: Keno Fischer <keno@juliacomputing.com>
> [Michael Roitzsch: - Rebase for NixOS]
> Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
> [Will Cohen: - Rebase to master]
> Signed-off-by: Will Cohen <wwcohen@gmail.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> [Will Cohen: - Add check for pthread_fchdir_np to virtfs]
> Signed-off-by: Will Cohen <wwcohen@gmail.com>
> ---
> fsdev/meson.build | 1 +
> meson.build | 14 ++++++++++----
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/fsdev/meson.build b/fsdev/meson.build
> index adf57cc43e..b632b66348 100644
> --- a/fsdev/meson.build
> +++ b/fsdev/meson.build
> @@ -7,6 +7,7 @@ fsdev_ss.add(when: ['CONFIG_FSDEV_9P'], if_true: files(
> 'qemu-fsdev.c',
> ), if_false: files('qemu-fsdev-dummy.c'))
> softmmu_ss.add_all(when: 'CONFIG_LINUX', if_true: fsdev_ss)
> +softmmu_ss.add_all(when: 'CONFIG_DARWIN', if_true: fsdev_ss)
>
> if have_virtfs_proxy_helper
> executable('virtfs-proxy-helper',
> diff --git a/meson.build b/meson.build
> index 5f43355071..6b4adf7e15 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1421,17 +1421,23 @@ if not get_option('dbus_display').disabled()
> endif
> endif
>
> -have_virtfs = (targetos == 'linux' and
> +if targetos == 'darwin' and cc.has_function('pthread_fchdir_np')
> + have_virtfs = have_system
As you are going for a v5 anyway: I would add an error message here if
pthread_fchdir_np() is not available. Because it is a bit frustrating for
users if their options silently got ignored without any indication why.
> +else
> + have_virtfs = (targetos == 'linux' and
> have_system and
> libattr.found() and
> libcap_ng.found())
> +endif
>
> -have_virtfs_proxy_helper = have_virtfs and have_tools
> +have_virtfs_proxy_helper = targetos == 'linux' and have_virtfs and
> have_tools
>
> if get_option('virtfs').enabled()
> if not have_virtfs
> - if targetos != 'linux'
> - error('virtio-9p (virtfs) requires Linux')
> + if targetos != 'linux' and targetos != 'darwin'
> + error('virtio-9p (virtfs) requires Linux or Darwin')
> + elif targetos == 'darwin' and not cc.has_function('pthread_fchdir_np')
> + error('virtio-9p (virtfs) on Darwin requires the presence of
> pthread_fchdir_np') elif not libcap_ng.found() or not libattr.found()
> error('virtio-9p (virtfs) requires libcap-ng-devel and
> libattr-devel') elif not have_system
- Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat, (continued)
- [PATCH v4 05/11] 9p: darwin: Ignore O_{NOATIME, DIRECT}, Will Cohen, 2022/02/06
- [PATCH v4 07/11] 9p: darwin: *xattr_nofollow implementations, Will Cohen, 2022/02/06
- [PATCH v4 10/11] 9p: darwin: meson: Allow VirtFS on Darwin, Will Cohen, 2022/02/06
- Re: [PATCH v4 10/11] 9p: darwin: meson: Allow VirtFS on Darwin, Philippe Mathieu-Daudé, 2022/02/06
- Re: [PATCH v4 10/11] 9p: darwin: meson: Allow VirtFS on Darwin, Will Cohen, 2022/02/06
- Re: [PATCH v4 10/11] 9p: darwin: meson: Allow VirtFS on Darwin, Christian Schoenebeck, 2022/02/07
- Re: [PATCH v4 10/11] 9p: darwin: meson: Allow VirtFS on Darwin, Will Cohen, 2022/02/07
- Re: [PATCH v4 10/11] 9p: darwin: meson: Allow VirtFS on Darwin, Greg Kurz, 2022/02/07
- Re: [PATCH v4 10/11] 9p: darwin: meson: Allow VirtFS on Darwin, Christian Schoenebeck, 2022/02/07
Re: [PATCH v4 10/11] 9p: darwin: meson: Allow VirtFS on Darwin,
Christian Schoenebeck <=
[PATCH v4 11/11] 9p: darwin: Adjust assumption on virtio-9p-test, Will Cohen, 2022/02/06
Re: [PATCH v4 00/11] 9p: Add support for darwin, Christian Schoenebeck, 2022/02/07