qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] memory: Fix qemu crash on starting dirty log twice with stop


From: Paolo Bonzini
Subject: Re: [PATCH] memory: Fix qemu crash on starting dirty log twice with stopped VM
Date: Tue, 8 Feb 2022 09:11:31 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 2/7/22 11:36, Peter Xu wrote:
Yeah I can do.  Though the latter "if (!flags)" check will also start to allow
nesting of memory_global_dirty_log_start(), and it'll make this assert useless:

     assert(!(global_dirty_tracking & flags));

I'll probably drop it too, then.

Curious: do we have any real case of nesting calls of starting dirty log?  I
always thought there's none, but I could miss something.

I don't think so, but I think there's no disadvantage in allowing it.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]