Re: [PATCH 21/27] qga/vss: use standard windows headers location

[Konstantin Kostiuk]

Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>

On Fri, Feb 4, 2022 at 7:18 AM Philippe Mathieu-Daudé via <qemu-devel@nongnu.org> wrote:

On 3/2/22 18:33, Paolo Bonzini wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Stop using special paths with outdated headers from an old SDK.
>
> Instead, use standard include paths.
>
> You can still build against the old SDK by running configure with
> --extra-cxxflags="-isystem `/path/to/inc/win2003/"

Superfluous back quote.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> (this also allows to build against MinGW headers, which are currently
> broken as in 9.0)
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   qga/vss-win32/install.cpp   | 2 +-
>   qga/vss-win32/provider.cpp  | 4 ++--
>   qga/vss-win32/requester.cpp | 4 ++--
>   qga/vss-win32/vss-common.h  | 6 +-----
>   4 files changed, 6 insertions(+), 10 deletions(-)