qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] tests/qtest: add qtests for npcm7xx sdhci


From: Patrick Venture
Subject: Re: [PATCH v2] tests/qtest: add qtests for npcm7xx sdhci
Date: Tue, 8 Feb 2022 08:55:41 -0800



On Mon, Feb 7, 2022 at 3:07 PM Patrick Venture <venture@google.com> wrote:


On Mon, Feb 7, 2022 at 9:34 AM Peter Maydell <peter.maydell@linaro.org> wrote:
On Sun, 6 Feb 2022 at 01:41, Patrick Venture <venture@google.com> wrote:
>
> From: Shengtan Mao <stmao@google.com>
>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
> Reviewed-by: Chris Rauer <crauer@google.com>
> Signed-off-by: Shengtan Mao <stmao@google.com>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
> v2:
>  * update copyright year
>  * check result of open
>  * use g_free instead of free
>  * move declarations to the top
>  * use g_file_open_tmp

Fails to compile:

../../tests/qtest/npcm7xx_sdhci-test.c:121:32: error: use of
undeclared identifier 'NPCM7XX_REG_SIZE'
    uint64_t end_addr = addr + NPCM7XX_REG_SIZE;
                               ^

Thanks. I must have only compiled at a part-way point while tweaking it.  I'll see if it compiles for me, and then figure out why it does when it doesn't, or if it doesn't, then obviously fix it.  Either way, will fix in v3, thanks.

Validated that when I build it, it's not getting built :)  So that's why this slipped through.  I'll dig into the history to see what this value should be now.
 
 


-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]