qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Revert "check-block: replace -makecheck with TAP output"


From: Thomas Huth
Subject: Re: [PATCH] Revert "check-block: replace -makecheck with TAP output"
Date: Wed, 9 Feb 2022 08:32:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 08/02/2022 17.21, Paolo Bonzini wrote:
On 2/8/22 15:51, Thomas Huth wrote:
On 08/02/2022 13.44, Paolo Bonzini wrote:
This reverts commit d316859f4e28c74ab8b618895d2a5e0a865d3cf1.  The
TAP output is inferior in that it does not include the diff for
failed tests.

What about dumping the output of meson-logs/testlog.txt instead? The diff also shows up there!

It does, but sort of by accident because it's not valid TAP (and in fact it continues with a TAP parsing error).

Ok, then let's try to go with my series (I'm working on a v2 right now) and the additional patch that prints out the diff to stderr instead of stdout, please ... I hope that should be good enough, and certainly looks way nicer than reverting to the old way of running the iotests.

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]