|
| From: | Philippe Mathieu-Daudé |
| Subject: | Re: [RFC PATCH] tcg/optimize: only read val after const check |
| Date: | Wed, 9 Feb 2022 12:55:50 +0100 |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 |
On 9/2/22 12:21, Alex Bennée wrote:
valgrind pointed out that arg_info()->val can be undefined which will be the case if the arguments are not constant. The ordering of the checks will have ensured we never relied on an undefined value but for the sake of completeness re-order the code to be clear. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- tcg/optimize.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
| [Prev in Thread] | Current Thread | [Next in Thread] |