[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] include: Move hardware version declarations to new qemu/
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 5/5] include: Move hardware version declarations to new qemu/hw-version.h |
|
Date: |
Wed, 9 Feb 2022 13:44:11 +0000 |
On Wed, 9 Feb 2022 at 10:10, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> On 9/2/22 10:25, Peter Maydell wrote:
> > On Wed, 9 Feb 2022 at 09:20, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> > I'm not completely convinced that (a) we have a clear idea of
> > what of our APIs are legacy and what are not or (b) that we could
> > coherently move the 'legacy' ones into separate files.
> > If you want to propose something like that as an RFC, I don't
> > 100% object to it, but I don't want to do a very small subset
> > of that as part of what is really just a "get stuff out of osdep"
> > series.
>
> OK, thanks.
Thinking about the 'legacy API' issue a bit, rather than putting
them in particular include paths, maybe we could have a file
we list them in, and have checkpatch automatically check for new
uses of them. But I think our major problems with legacy APIs are
more "we never go through and complete transitions" rather than
"new code coming in uses old APIs we're trying to move away from"...
-- PMM
[PATCH 3/5] include: Move QEMU_MAP_* constants to mmap-alloc.h, Peter Maydell, 2022/02/08
[PATCH 4/5] include: Move qemu_[id]cache_* declarations to new qemu/cacheinfo.h, Peter Maydell, 2022/02/08
[PATCH 2/5] include: Move qemu_mprotect_*() to new qemu/mprotect.h, Peter Maydell, 2022/02/08
Re: [PATCH 0/5] include: Trim some fat from osdep.h, Philippe Mathieu-Daudé, 2022/02/09
Re: [PATCH 0/5] include: Trim some fat from osdep.h, Peter Maydell, 2022/02/18