qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/13] exec: Move translation declarations to 'translate-all.


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 13/13] exec: Move translation declarations to 'translate-all.h'
Date: Wed, 9 Feb 2022 22:50:58 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1

On 9/2/22 00:00, Richard Henderson wrote:
On 2/9/22 02:22, Philippe Mathieu-Daudé wrote:
Translation declarations are only useful to TCG accelerator.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Ug.

So, like, what's you vision of exec-all.h vs translate-all.h? Certainly there's not much in translate-all.h at the moment. Taking a case at random, what has gdbstub.c got to do with "translation" as opposed to "execution"?

I would expect some documetation updates to the top of these headers.  I don't see why everything has to move all at once, especially since translate-all.h already includes exec-all.h.

I can see that exec-all.h is currently a garbage bag, but I strongly suspect that you're moving too much here.

I ended with an almost empty exec-all.h; IOW indeed translate-all.h and
exec-all.h are the same mixed bag. What I'm pursuing is extract APIs
such migration and ramblock stuff, but there are so many inter
dependencies that it is hard to sort the patchset (or split it in
series on the same topic but no more than 20 patches).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]