Re: [PATCH 1/4] hw/openrisc/openrisc_sim: Create machine state for or1ksim

[Stafford Horne]

On Thu, Feb 10, 2022 at 12:05:22PM +0100, Philippe Mathieu-Daudé wrote:
> On 10/2/22 07:30, Stafford Horne wrote:
> > This will allow us to attach machine state attributes like
> > the device tree fdt.
> > 
> > Signed-off-by: Stafford Horne <shorne@gmail.com>
> > ---
> >   hw/openrisc/openrisc_sim.c | 31 +++++++++++++++++++++++++++++--
> >   1 file changed, 29 insertions(+), 2 deletions(-)
> 
> > @@ -141,6 +153,7 @@ static void openrisc_sim_init(MachineState *machine)
> >       ram_addr_t ram_size = machine->ram_size;
> >       const char *kernel_filename = machine->kernel_filename;
> >       OpenRISCCPU *cpus[2] = {};
> > +    Or1ksimState *s = OR1KSIM_MACHINE(machine);
> 
> This change belong to patch #3.

Yes, when I was splitting this patch out I left it here because I was
"preparing".  But it is not being used, so fair enough.

> Otherwise:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Thanks

> >       MemoryRegion *ram;
> >       qemu_irq serial_irq;
> >       int n;
> > @@ -183,8 +196,10 @@ static void openrisc_sim_init(MachineState *machine)
> >       openrisc_load_kernel(ram_size, kernel_filename);
> >   }