[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/42] target/ppc: Fix radix logging
From: |
Cédric Le Goater |
Subject: |
[PULL 13/42] target/ppc: Fix radix logging |
Date: |
Thu, 10 Feb 2022 13:59:39 +0100 |
ppc_radix64_partition_scoped_xlate() logs the host page protection
bits variable but it is uninitialized. The value is set later on in
ppc_radix64_check_prot(). Remove the output.
Fixes: Coverity CID 1468942
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <20220203142145.1301749-1-clg@kaod.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
target/ppc/mmu-radix64.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
index 040c055bff65..d4e16bd7db50 100644
--- a/target/ppc/mmu-radix64.c
+++ b/target/ppc/mmu-radix64.c
@@ -327,13 +327,9 @@ static int ppc_radix64_partition_scoped_xlate(PowerPCCPU
*cpu,
uint64_t pte;
qemu_log_mask(CPU_LOG_MMU, "%s for %s @0x%"VADDR_PRIx
- " mmu_idx %u (prot %c%c%c) 0x%"HWADDR_PRIx"\n",
+ " mmu_idx %u 0x%"HWADDR_PRIx"\n",
__func__, access_str(access_type),
- eaddr, mmu_idx,
- *h_prot & PAGE_READ ? 'r' : '-',
- *h_prot & PAGE_WRITE ? 'w' : '-',
- *h_prot & PAGE_EXEC ? 'x' : '-',
- g_raddr);
+ eaddr, mmu_idx, g_raddr);
*h_page_size = PRTBE_R_GET_RTS(pate.dw0);
/* No valid pte or access denied due to protection */
--
2.34.1
- [PULL 02/42] target/ppc: Introduce powerpc_excp_booke, (continued)
- [PULL 02/42] target/ppc: Introduce powerpc_excp_booke, Cédric Le Goater, 2022/02/10
- [PULL 31/42] target/ppc: 7xx: Program exception cleanup, Cédric Le Goater, 2022/02/10
- [PULL 21/42] target/ppc: 6xx: Program exception cleanup, Cédric Le Goater, 2022/02/10
- [PULL 24/42] target/ppc: 6xx: Software TLB exceptions cleanup, Cédric Le Goater, 2022/02/10
- [PULL 25/42] target/ppc: 6xx: Set SRRs directly in exception code, Cédric Le Goater, 2022/02/10
- [PULL 36/42] target/ppc: Remove powerpc_excp_legacy, Cédric Le Goater, 2022/02/10
- [PULL 37/42] target/ppc: powerpc_excp: Move common code to the caller function, Cédric Le Goater, 2022/02/10
- [PULL 23/42] target/ppc: 6xx: System Reset interrupt cleanup, Cédric Le Goater, 2022/02/10
- [PULL 08/42] target/ppc: booke: External interrupt cleanup, Cédric Le Goater, 2022/02/10
- [PULL 10/42] target/ppc: booke: System Call exception cleanup, Cédric Le Goater, 2022/02/10
- [PULL 13/42] target/ppc: Fix radix logging,
Cédric Le Goater <=
- [PULL 35/42] target/ppc: 7xx: Set SRRs directly in exception code, Cédric Le Goater, 2022/02/10
- [PULL 29/42] target/ppc: 7xx: Machine Check exception cleanup, Cédric Le Goater, 2022/02/10
- [PULL 17/42] target/ppc: Simplify powerpc_excp_6xx, Cédric Le Goater, 2022/02/10
- [PULL 39/42] target/ppc: books: Remove excp_model argument from ppc_excp_apply_ail, Cédric Le Goater, 2022/02/10
- [PULL 40/42] target/ppc: Change VSX instructions behavior to fill with zeros, Cédric Le Goater, 2022/02/10
- [PULL 38/42] target/ppc: Assert if MSR bits differ from msr_mask during exceptions, Cédric Le Goater, 2022/02/10
- [PULL 41/42] docs: rstfy confidential guest documentation, Cédric Le Goater, 2022/02/10
- [PULL 34/42] target/ppc: 7xx: Software TLB cleanup, Cédric Le Goater, 2022/02/10
- [PULL 27/42] target/ppc: Introduce powerpc_excp_7xx, Cédric Le Goater, 2022/02/10
- Re: [PULL 00/42] ppc queue, Peter Maydell, 2022/02/14