[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/20] migration: Dump ramblock and offset too when non-same-page
From: |
Peter Xu |
Subject: |
[PATCH 05/20] migration: Dump ramblock and offset too when non-same-page detected |
Date: |
Wed, 16 Feb 2022 14:27:54 +0800 |
In ram_load_postcopy() we'll try to detect non-same-page case and dump error.
This error is very helpful for debugging. Adding ramblock & offset into the
error log too.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/ram.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 36b0a53afe..87bcb704d4 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3706,8 +3706,12 @@ static int ram_load_postcopy(QEMUFile *f)
} else if (tmp_page->host_addr !=
host_page_from_ram_block_offset(block, addr)) {
/* not the 1st TP within the HP */
- error_report("Non-same host page %p/%p", tmp_page->host_addr,
- host_page_from_ram_block_offset(block, addr));
+ error_report("Non-same host page detected. Target host page
%p, "
+ "received host page %p "
+ "(rb %s offset 0x"RAM_ADDR_FMT" target_pages %d)",
+ tmp_page->host_addr,
+ host_page_from_ram_block_offset(block, addr),
+ block->idstr, addr, tmp_page->target_pages);
ret = -EINVAL;
break;
}
--
2.32.0
- [PATCH 00/20] migration: Postcopy Preemption, Peter Xu, 2022/02/16
- [PATCH 01/20] migration: Dump sub-cmd name in loadvm_process_command tp, Peter Xu, 2022/02/16
- [PATCH 03/20] migration: Tracepoint change in postcopy-run bottom half, Peter Xu, 2022/02/16
- [PATCH 04/20] migration: Introduce postcopy channels on dest node, Peter Xu, 2022/02/16
- [PATCH 02/20] migration: Finer grained tracepoints for POSTCOPY_LISTEN, Peter Xu, 2022/02/16
- [PATCH 05/20] migration: Dump ramblock and offset too when non-same-page detected,
Peter Xu <=
- [PATCH 06/20] migration: Add postcopy_thread_create(), Peter Xu, 2022/02/16
- [PATCH 07/20] migration: Move static var in ram_block_from_stream() into global, Peter Xu, 2022/02/16
- [PATCH 08/20] migration: Add pss.postcopy_requested status, Peter Xu, 2022/02/16
- [PATCH 09/20] migration: Move migrate_allow_multifd and helpers into migration.c, Peter Xu, 2022/02/16
- [PATCH 10/20] migration: Enlarge postcopy recovery to capture !-EIO too, Peter Xu, 2022/02/16
- [PATCH 11/20] migration: postcopy_pause_fault_thread() never fails, Peter Xu, 2022/02/16
- [PATCH 12/20] migration: Export ram_load_postcopy(), Peter Xu, 2022/02/16