[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 22/27] target/ppc: cpu_init: Rename register_ne_601_sprs
From: |
Fabiano Rosas |
Subject: |
Re: [PATCH 22/27] target/ppc: cpu_init: Rename register_ne_601_sprs |
Date: |
Wed, 16 Feb 2022 10:19:40 -0300 |
David Gibson <david@gibson.dropbear.id.au> writes:
> On Tue, Feb 15, 2022 at 06:41:43PM -0300, Fabiano Rosas wrote:
>> The important part of this function is that it applies to non-embedded
>> CPUs, not that it also applies to the 601. We removed support for the
>> 601 anyway, so rename this function.
>>
>> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>
> Although, I wonder if "books_common" or something might be a better
> name, though. Admittedly, I don't think the "BookS" terminology
> existed at the time of most of these earlier CPUs. However, these
> days the majority of 7xx chips are probably in embedded applications,
> even if they weren't designed for an embedded chip line.
The 'ne' in the original name was probably meant to signify
not-BookE. So non_booke perhaps would work? The thing with calling it
books_common is that we're using BookS only for the 970 and upwards and
this function applies to 6xx, 7xx, 74xx as well.
- [PATCH 21/27] target/ppc: cpu_init: Rename software TLB function, (continued)
- [PATCH 21/27] target/ppc: cpu_init: Rename software TLB function, Fabiano Rosas, 2022/02/15
- [PATCH 24/27] target/ppc: cpu_init: Expose some SPR registration helpers, Fabiano Rosas, 2022/02/15
- [PATCH 14/27] target/ppc: cpu_init: Deduplicate 755 SPR registration, Fabiano Rosas, 2022/02/15
- [PATCH 23/27] target/ppc: cpu_init: Remove register_usprg3_sprs, Fabiano Rosas, 2022/02/15
- [PATCH 22/27] target/ppc: cpu_init: Rename register_ne_601_sprs, Fabiano Rosas, 2022/02/15
- [PATCH 17/27] target/ppc: cpu_init: Move 604e SPR registration into a function, Fabiano Rosas, 2022/02/15
- [PATCH 19/27] target/ppc: cpu_init: Reuse init_proc_604 for the 604e, Fabiano Rosas, 2022/02/15
- [PATCH 15/27] target/ppc: cpu_init: Move 755 L2 cache SPRs into a function, Fabiano Rosas, 2022/02/15
- [PATCH 20/27] target/ppc: cpu_init: Reuse init_proc_745 for the 755, Fabiano Rosas, 2022/02/15