[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 05/12] virtiofsd: Extend size of fuse_conn_info->capable and ->wan
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 05/12] virtiofsd: Extend size of fuse_conn_info->capable and ->want fields |
Date: |
Thu, 17 Feb 2022 14:23:55 +0000 |
From: Vivek Goyal <vgoyal@redhat.com>
->capable keeps track of what capabilities kernel supports and ->wants keep
track of what capabilities filesytem wants.
Right now these fields are 32bit in size. But now fuse has run out of
bits and capabilities can now have bit number which are higher than 31.
That means 32 bit fields are not suffcient anymore. Increase size to 64
bit so that we can add newer capabilities and still be able to use existing
code to check and set the capabilities.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Message-Id: <20220208204813.682906-5-vgoyal@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
tools/virtiofsd/fuse_common.h | 4 ++--
tools/virtiofsd/fuse_lowlevel.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/virtiofsd/fuse_common.h b/tools/virtiofsd/fuse_common.h
index 0c2665b977..6f8a988202 100644
--- a/tools/virtiofsd/fuse_common.h
+++ b/tools/virtiofsd/fuse_common.h
@@ -439,7 +439,7 @@ struct fuse_conn_info {
/**
* Capability flags that the kernel supports (read-only)
*/
- unsigned capable;
+ uint64_t capable;
/**
* Capability flags that the filesystem wants to enable.
@@ -447,7 +447,7 @@ struct fuse_conn_info {
* libfuse attempts to initialize this field with
* reasonable default values before calling the init() handler.
*/
- unsigned want;
+ uint64_t want;
/**
* Maximum number of pending "background" requests. A
diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c
index b6712b763a..d91cd9743a 100644
--- a/tools/virtiofsd/fuse_lowlevel.c
+++ b/tools/virtiofsd/fuse_lowlevel.c
@@ -2069,7 +2069,7 @@ static void do_init(fuse_req_t req, fuse_ino_t nodeid,
if (se->conn.want & (~se->conn.capable)) {
fuse_log(FUSE_LOG_ERR,
"fuse: error: filesystem requested capabilities "
- "0x%x that are not supported by kernel, aborting.\n",
+ "0x%llx that are not supported by kernel, aborting.\n",
se->conn.want & (~se->conn.capable));
fuse_reply_err(req, EPROTO);
se->error = -EPROTO;
--
2.35.1
- [PULL 11/12] virtiofsd: Add an option to enable/disable security label, (continued)
- [PULL 11/12] virtiofsd: Add an option to enable/disable security label, Dr. David Alan Gilbert (git), 2022/02/16
- [PULL 12/12] virtiofsd: Add basic support for FUSE_SYNCFS request, Dr. David Alan Gilbert (git), 2022/02/16
- Re: [Virtio-fs] [PULL 00/12] virtiofs queue, Dr. David Alan Gilbert, 2022/02/16
- [PULL 00/12] virtiofs queue, Dr. David Alan Gilbert (git), 2022/02/17
- [PULL 02/12] virtiofsd: Fix breakage due to fuse_init_in size change, Dr. David Alan Gilbert (git), 2022/02/17
- [PULL 01/12] virtiofsd: Do not support blocking flock, Dr. David Alan Gilbert (git), 2022/02/17
- [PULL 03/12] linux-headers: Update headers to v5.17-rc1, Dr. David Alan Gilbert (git), 2022/02/17
- [PULL 04/12] virtiofsd: Parse extended "struct fuse_init_in", Dr. David Alan Gilbert (git), 2022/02/17
- [PULL 05/12] virtiofsd: Extend size of fuse_conn_info->capable and ->want fields,
Dr. David Alan Gilbert (git) <=
- [PULL 06/12] virtiofsd, fuse_lowlevel.c: Add capability to parse security context, Dr. David Alan Gilbert (git), 2022/02/17
- [PULL 07/12] virtiofsd: Move core file creation code in separate function, Dr. David Alan Gilbert (git), 2022/02/17
- [PULL 08/12] virtiofsd: Add helpers to work with /proc/self/task/tid/attr/fscreate, Dr. David Alan Gilbert (git), 2022/02/17
- [PULL 09/12] virtiofsd: Create new file with security context, Dr. David Alan Gilbert (git), 2022/02/17
- [PULL 10/12] virtiofsd: Create new file using O_TMPFILE and set security context, Dr. David Alan Gilbert (git), 2022/02/17
- [PULL 11/12] virtiofsd: Add an option to enable/disable security label, Dr. David Alan Gilbert (git), 2022/02/17
- [PULL 12/12] virtiofsd: Add basic support for FUSE_SYNCFS request, Dr. David Alan Gilbert (git), 2022/02/17
- Re: [Virtio-fs] [PULL 00/12] virtiofs queue, Dr. David Alan Gilbert, 2022/02/17
- [PULL 00/12] virtiofs queue, Dr. David Alan Gilbert (git), 2022/02/17