qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/4] block: improve block_dirty_bitmap_merge(): don't allocat


From: Nikta Lapshin
Subject: Re: [PATCH 3/4] block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap
Date: Sat, 19 Feb 2022 13:29:11 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0


On 2/15/22 20:53, Vladimir Sementsov-Ogievskiy wrote:
We don't need extra bitmap. All we need is to backup the original
bitmap when we do first merge. So, drop extra temporary bitmap and work
directly with target and backup.

Note that block_dirty_bitmap_merge() semantics changed: on failure
target may be modified now, and caller should call
block_dirty_bitmap_restore() if needed. The only caller is
qmp_transaction() and ->abort() is called for failed action. So, we are
OK.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 block/monitor/bitmap-qmp-cmds.c | 31 +++++++++----------------------
 1 file changed, 9 insertions(+), 22 deletions(-)

Reviewed-by: Nikita Lapshin <nikita.lapshin@virtuozzo.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]