Re: [PATCH 15/20] migration: Allow migrate-recover to run multiple times

[Peter Xu]

On Mon, Feb 21, 2022 at 05:03:24PM +0000, Dr. David Alan Gilbert wrote:
> * Peter Xu (peterx@redhat.com) wrote:
> > Previously migration didn't have an easy way to cleanup the listening
> > transport, migrate recovery only allows to execute once.  That's done with a
> > trick flag in postcopy_recover_triggered.
> > 
> > Now the facility is already there.
> > 
> > Drop postcopy_recover_triggered and instead allows a new migrate-recover to
> > release the previous listener transport.
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> 
> OK, was that the only reason you couldn't recover twice?

We could recover twice, but we couldn't specify the listening port twice
because AFAIU previously we don't have a good way to clean the existing
listener.

IOW we could always run pause->recover->pause->recover sequence even before
this patch[set], but we can never run continuous recover->recover because
the 2nd one will fail telling that we've already setup a recovery port.

> 
> 
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Thanks!

-- 
Peter Xu