Re: [PATCH v4 34/47] target/ppc: move xs[n]madd[am][ds]p/xs[n]msub[am][ds]p to decodetree

[Richard Henderson]

On 2/22/22 04:36, matheus.ferst@eldorado.org.br wrote:
> +static bool do_xsmadd(DisasContext *ctx, int tgt, int src1, int src2, int src3,
> +        void (gen_helper)(TCGv_ptr, TCGv_ptr, TCGv_ptr, TCGv_ptr, TCGv_ptr))

Missing a * before gen_helper.  Somewhat surprised this compiled...

> +static bool do_xsmadd_XX3(DisasContext *ctx, arg_XX3 *a, bool type_a,
> +        void (gen_helper)(TCGv_ptr, TCGv_ptr, TCGv_ptr, TCGv_ptr, TCGv_ptr))

Likewise.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~