qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] hw/i2c: flatten pca954x mux device


From: Patrick Venture
Subject: Re: [PATCH v2] hw/i2c: flatten pca954x mux device
Date: Thu, 24 Feb 2022 10:52:52 -0800



On Thu, Feb 24, 2022 at 2:56 AM Peter Maydell <peter.maydell@linaro.org> wrote:
On Wed, 2 Feb 2022 at 17:57, Patrick Venture <venture@google.com> wrote:
>
> Previously this device created N subdevices which each owned an i2c bus.
> Now this device simply owns the N i2c busses directly.
>
> Tested: Verified devices behind mux are still accessible via qmp and i2c
> from within an arm32 SoC.
>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
> Signed-off-by: Patrick Venture <venture@google.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2: explicitly create an incrementing name for the i2c busses (channels).
> ---

Applied to target-arm.next, thanks.

Apologies for not picking this up earlier, the v2 got lost in the
side-conversation about spam filtering. (Blame gmail for not
doing email threading properly if you like :-))

Thanks, and no problem.  This v2 is what we have downstream for this.

I'm working on a further improvement to it (separate feature change) that'll allow setting an id on the device so that all its channels have that the id embedded in them.  This'll handle some of the situations we're observing where the qdev paths aren't great for command line added i2c devices.  There's a side conversation going on about how best to accomplish this.
 

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]