qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/12] Replace config-time define HOST_WORDS_BIGENDIAN


From: Richard Henderson
Subject: Re: [PATCH 06/12] Replace config-time define HOST_WORDS_BIGENDIAN
Date: Thu, 24 Feb 2022 09:37:45 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 2/24/22 08:36, marcandre.lureau@redhat.com wrote:
From: Marc-André Lureau<marcandre.lureau@redhat.com>

Replace a config-time define with a compile time condition
define (compatible with clang and gcc) that must be declared prior to
its usage. This avoids having a global configure time define, but also
prevents from bad usage, if the config header wasn't included before.

This can help to make some code independent from qemu too.

gcc supports __BYTE_ORDER__ from about 4.6 and clang from 3.2.

Signed-off-by: Marc-André Lureau<marcandre.lureau@redhat.com>

Looks ok. I'd like HOST_WORDS_BIGENDIAN to be poisoned, so that we're assured that we've caught all uses and new ones don't creep back in.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]