Re: [PATCH v13 4/4] target/ppc: trigger PERFM EBBs from power8-pmu.c

qemu-devel

From:	Richard Henderson
Subject:	Re: [PATCH v13 4/4] target/ppc: trigger PERFM EBBs from power8-pmu.c
Date:	Thu, 24 Feb 2022 11:45:06 -1000
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 2/24/22 10:19, Daniel Henrique Barboza wrote:

+void helper_ebb_perfm_excp(CPUPPCState *env)

Please reserve the prefix "helper_" for something that is called from tcg generated code,which this is not.

r~

Current Thread

[Next in Thread]

[PATCH v13 0/4] PMU-EBB support for PPC64 TCG, Daniel Henrique Barboza, 2022/02/24
- [PATCH v13 1/4] target/ppc: make power8-pmu.c CONFIG_TCG only, Daniel Henrique Barboza, 2022/02/24
  - Re: [PATCH v13 1/4] target/ppc: make power8-pmu.c CONFIG_TCG only, Richard Henderson, 2022/02/24
- [PATCH v13 2/4] target/ppc: finalize pre-EBB PMU logic, Daniel Henrique Barboza, 2022/02/24
- [PATCH v13 3/4] target/ppc: add PPC_INTERRUPT_EBB and EBB exceptions, Daniel Henrique Barboza, 2022/02/24
- [PATCH v13 4/4] target/ppc: trigger PERFM EBBs from power8-pmu.c, Daniel Henrique Barboza, 2022/02/24
  - Re: [PATCH v13 4/4] target/ppc: trigger PERFM EBBs from power8-pmu.c, Richard Henderson <=
    - Re: [PATCH v13 4/4] target/ppc: trigger PERFM EBBs from power8-pmu.c, Daniel Henrique Barboza, 2022/02/25