Re: [PATCH] coreaudio: Notify error in coreaudio_init_out

[Christian Schoenebeck]

On Samstag, 26. Februar 2022 11:02:48 CET Akihiko Odaki wrote:
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
>  audio/coreaudio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/audio/coreaudio.c b/audio/coreaudio.c
> index d8a21d3e507..d7cfdcc4fc4 100644
> --- a/audio/coreaudio.c
> +++ b/audio/coreaudio.c
> @@ -604,6 +604,8 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct
> audsettings *as, coreaudio_playback_logerr(status,
>                                        "Could not remove voice property
> change listener\n"); }
> +
> +        return -1;
>      }
> 
>      return 0;

Is this a pure theoretical fix, or does it actually fix an actually 
encountered misbehaviour? I don't see any explanation in the commit log. I 
mean the branch here is about removing a listener only.

Best regards,
Christian Schoenebeck