qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/4] cutils: Introduce bundle mechanism


From: Akihiko Odaki
Subject: Re: [PATCH v2 0/4] cutils: Introduce bundle mechanism
Date: Sat, 26 Feb 2022 22:09:11 +0900
User-agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 2022/02/26 22:02, Peter Maydell wrote:
On Sat, 26 Feb 2022 at 12:45, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:

Developers often run QEMU without installing. The bundle mechanism
allows to look up files which should be present in installation even in
such a situation.

This is supposed to work already -- it is why find_datadir() looks
at a path based on qemu_get_exec_dir() as well as at the
CONFIG_QEMU_DATADIR.

If you want to replace that mechanism, you need to explain:
  * under what circumstances it isn't working correctly
  * why we should replace it with a different design rather
    than attempting to fix its bugs
  * why the design you're proposing is the right way to do that

The cover letter is a good place to explain that sort of
thing, so people understand why the patchset is doing what
it is before they dive into the detail.

thanks
-- PMM

datadir is only for pc-bios and does not include icons and qemu-bridge-helper. find_bundle is a general mechanism which can be used for any files to be installed.

Regards,
Akihiko Odaki



reply via email to

[Prev in Thread] Current Thread [Next in Thread]