qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/22] bsd-user/bsd-file.h: Implementation details for the fi


From: Warner Losh
Subject: Re: [PATCH 13/22] bsd-user/bsd-file.h: Implementation details for the filesystem calls
Date: Sat, 26 Feb 2022 09:24:48 -0700



On Tue, Feb 1, 2022 at 10:43 AM Richard Henderson <richard.henderson@linaro.org> wrote:
On 2/1/22 22:14, Warner Losh wrote:
> +#ifndef BSD_FILE_H_
> +#define BSD_FILE_H_
> +
> +#include <sys/types.h>
> +#include <sys/mount.h>
> +#include <sys/uio.h>
> +#include <fcntl.h>
> +#include <poll.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <unistd.h>

Many of these should be done by "qemu/osdep.h" already.  Otherwise I question putting them
into this header, as opposed to as needed by other syscall handling c files.

Indeed. None of these are needed here. I've removed them. 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]