qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/9] meson.build: Don't misdetect posix_memalign() on Windows


From: Richard Henderson
Subject: Re: [PATCH 5/9] meson.build: Don't misdetect posix_memalign() on Windows
Date: Sat, 26 Feb 2022 14:52:26 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 2/26/22 08:07, Peter Maydell wrote:
Currently we incorrectly think that posix_memalign() exists on
Windows.  This is because of a combination of:

  * the msys2/mingw toolchain/libc claim to have a
    __builtin_posix_memalign when there isn't a builtin of that name
  * meson will assume that if you have a __builtin_foo that
    counts for has_function('foo')

Specifying a specific include file via prefix: causes meson to not
treat builtins as sufficient and actually look for the function
itself; see this meson pull request which added that as the official
way to get the right answer:
   https://github.com/mesonbuild/meson/pull/1150

Currently this misdectection doesn't cause problems because we only
use CONFIG_POSIX_MEMALIGN in oslib-posix.c; however that will change
in a following commit.

Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---
  meson.build | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]