RE: [PATCH v2 1/4] target/nios2: Shadow register set

[Amir Gonnen]

Hi Richard,

Thank you for your review and comments!

> You're missing a gen_check_supervisor here and in wrprs.

There's something I don't understand about gen_check_supervisor - it looks like 
it checks CR_STATUS_U when generating code instead of generating code that 
checks CR_STATUS_U.
Is that correct to assume that CR_STATUS_U would remain the same between 
generation and runtime?

> As an existing bug to be fixed by a separate patch, eret should also check 
> for supervisor.

Do you suggest I shouldn't fix this here? Why not fix this anyway?

> You really need to suppress these footers when posting to a public mailing 
> list.

I'm sorry about that.
I've worked with IT team to disable this automatic footer when sending to the 
mailing list so it shouldn't appear any more in the list, but it may still 
appear for individual recipients.
So, if this still annoys anyone please let me know and I'll contact them again 
for a different solution.