Re: [PATCH v4] ui/cocoa: Use NSWindow's ability to resize

[Akihiko Odaki]

On 2022/02/27 23:56, Peter Maydell wrote:
> On Sat, 26 Feb 2022 at 10:41, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
> > This change brings two new features:
> > - The window will be resizable if "Zoom To Fit" is eanbled
> > - The window can be made full screen by clicking full screen button
> >    provided by the platform. (The left-top green button.)
> >
> > Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> > ---
> >   ui/cocoa.m | 543 +++++++++++++++++++++++++----------------------------
> >   1 file changed, 252 insertions(+), 291 deletions(-)
>
> This is making too many changes in a single patch to be
> reviewable -- can you break it down into more digestible
> chunks, please?
>
> thanks
> -- PMM

Unfortunately it is not possible. The most of the change is caused by 
the convergence of two windows (full screen window and normal window) 
into one. ui/cocoa depends on them for coordinate calculations and event 
handling, which happens basically everywhere in QemuCocoaView. The old 
implementation with two distinct windows and the new one with a unified 
window are essentially incompatible and cannot be mixed.

Regards,
Akihiko Odaki