On 2/24/22 18:04, Marc-André Lureau wrote:
> Paolo,
>
> This patch is ok, but in some (new?) circumstances it fails with freebsd
> and reveals that -lutil was missing for kinfo_getproc() in
> util/oslib-posix.c. Please add:
>
> -util_ss.add(when: 'CONFIG_POSIX', if_true: files('oslib-posix.c'))
> +util_ss.add(when: 'CONFIG_POSIX', if_true: [files('oslib-posix.c'), util])
>
> (even better if we made this specific to freebsd I guess, but not
> strictly necessary)
Looking again at the patch (because indeed it broke CI :)), I'm not sure
it's a good idea. The code seems to be partly taken from other projects
and doesn't follow the QEMU coding standards.
One more reason imho to not have this in the common qemuutil library.
Apparently, the helper was added in 2008, commit 64b7b7334b ("Put Pseudo-TTY in rawmode for char devices") and it is not necessary since Solaris 11.4 (see commit 9df8b20d1). I am not sure we need to maintain compatibility with Solaris <11.4 (released on Aug 2018) tbh. According to wikipedia page, 11.3 is maintained until January 2024. Maybe wait until that and drop it?
Do you have a branch where you have queued the accepted patches? I can rebase, fix the linking on freebsd, fix style and resend.