[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/9] scripts/qapi: minor delinting
From: |
Markus Armbruster |
Subject: |
[PULL 1/9] scripts/qapi: minor delinting |
Date: |
Mon, 28 Feb 2022 12:26:05 +0100 |
From: John Snow <jsnow@redhat.com>
Get isort and pylint tools passing again.
Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20220211183650.2946895-1-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Comment explaining good-names-rgxs tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
scripts/qapi/commands.py | 2 +-
scripts/qapi/pylintrc | 16 ++++++----------
scripts/qapi/types.py | 6 +++++-
scripts/qapi/visit.py | 6 +++++-
4 files changed, 17 insertions(+), 13 deletions(-)
diff --git a/scripts/qapi/commands.py b/scripts/qapi/commands.py
index 869d799ed2..38ca38a7b9 100644
--- a/scripts/qapi/commands.py
+++ b/scripts/qapi/commands.py
@@ -25,8 +25,8 @@
QAPIGenC,
QAPISchemaModularCVisitor,
build_params,
- ifcontext,
gen_special_features,
+ ifcontext,
)
from .schema import (
QAPISchema,
diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
index b259531a72..a724628203 100644
--- a/scripts/qapi/pylintrc
+++ b/scripts/qapi/pylintrc
@@ -34,16 +34,12 @@ disable=fixme,
[BASIC]
-# Good variable names which should always be accepted, separated by a comma.
-good-names=i,
- j,
- k,
- ex,
- Run,
- _,
- fp, # fp = open(...)
- fd, # fd = os.open(...)
- ch,
+# Good variable names regexes, separated by a comma. If names match any regex,
+# they will always be accepted.
+#
+# Suppress complaints about short names. PEP-8 is cool with them,
+# and so are we.
+good-names-rgxs=^[_a-z][_a-z0-9]?$
[VARIABLES]
diff --git a/scripts/qapi/types.py b/scripts/qapi/types.py
index 3013329c24..477d027001 100644
--- a/scripts/qapi/types.py
+++ b/scripts/qapi/types.py
@@ -16,7 +16,11 @@
from typing import List, Optional
from .common import c_enum_const, c_name, mcgen
-from .gen import QAPISchemaModularCVisitor, gen_special_features, ifcontext
+from .gen import (
+ QAPISchemaModularCVisitor,
+ gen_special_features,
+ ifcontext,
+)
from .schema import (
QAPISchema,
QAPISchemaEnumMember,
diff --git a/scripts/qapi/visit.py b/scripts/qapi/visit.py
index e13bbe4292..380fa197f5 100644
--- a/scripts/qapi/visit.py
+++ b/scripts/qapi/visit.py
@@ -21,7 +21,11 @@
indent,
mcgen,
)
-from .gen import QAPISchemaModularCVisitor, gen_special_features, ifcontext
+from .gen import (
+ QAPISchemaModularCVisitor,
+ gen_special_features,
+ ifcontext,
+)
from .schema import (
QAPISchema,
QAPISchemaEnumMember,
--
2.35.1
- [PULL 0/9] QAPI patches patches for 2022-02-28, Markus Armbruster, 2022/02/28
- [PULL 7/9] hw/rtc: Compile pl031 once-only, Markus Armbruster, 2022/02/28
- [PULL 6/9] qapi: Document some missing details of RTC_CHANGE event, Markus Armbruster, 2022/02/28
- [PULL 3/9] qapi: Fix stale reference to scripts/qapi.py in a comment, Markus Armbruster, 2022/02/28
- [PULL 4/9] qapi/migration: Fix examples document wrong field name for arguments, Markus Armbruster, 2022/02/28
- [PULL 5/9] qapi: Move RTC_CHANGE back out of target schema, Markus Armbruster, 2022/02/28
- [PULL 8/9] rtc: Have event RTC_CHANGE identify the RTC by QOM path, Markus Armbruster, 2022/02/28
- [PULL 2/9] keyval: Fix grammar comment to cover downstream prefix, Markus Armbruster, 2022/02/28
- [PULL 9/9] qapi: Belatedly adjust limitations documentation, Markus Armbruster, 2022/02/28
- [PULL 1/9] scripts/qapi: minor delinting,
Markus Armbruster <=