[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 03/16] block/block-copy: block_copy_state_new(): add bitmap pa
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v5 03/16] block/block-copy: block_copy_state_new(): add bitmap parameter |
Date: |
Mon, 28 Feb 2022 12:39:14 +0100 |
This will be used in the following commit to bring "incremental" mode
to copy-before-write filter.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
---
include/block/block-copy.h | 1 +
block/block-copy.c | 14 +++++++++++++-
block/copy-before-write.c | 2 +-
3 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/include/block/block-copy.h b/include/block/block-copy.h
index 99370fa38b..b80ad02299 100644
--- a/include/block/block-copy.h
+++ b/include/block/block-copy.h
@@ -25,6 +25,7 @@ typedef struct BlockCopyState BlockCopyState;
typedef struct BlockCopyCallState BlockCopyCallState;
BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
+ const BdrvDirtyBitmap *bitmap,
Error **errp);
/* Function should be called prior any actual copy request */
diff --git a/block/block-copy.c b/block/block-copy.c
index abda7a80bd..8aa6ee6a5c 100644
--- a/block/block-copy.c
+++ b/block/block-copy.c
@@ -384,8 +384,10 @@ static int64_t
block_copy_calculate_cluster_size(BlockDriverState *target,
}
BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
+ const BdrvDirtyBitmap *bitmap,
Error **errp)
{
+ ERRP_GUARD();
BlockCopyState *s;
int64_t cluster_size;
BdrvDirtyBitmap *copy_bitmap;
@@ -402,7 +404,17 @@ BlockCopyState *block_copy_state_new(BdrvChild *source,
BdrvChild *target,
return NULL;
}
bdrv_disable_dirty_bitmap(copy_bitmap);
- bdrv_set_dirty_bitmap(copy_bitmap, 0, bdrv_dirty_bitmap_size(copy_bitmap));
+ if (bitmap) {
+ if (!bdrv_merge_dirty_bitmap(copy_bitmap, bitmap, NULL, errp)) {
+ error_prepend(errp, "Failed to merge bitmap '%s' to internal "
+ "copy-bitmap: ", bdrv_dirty_bitmap_name(bitmap));
+ bdrv_release_dirty_bitmap(copy_bitmap);
+ return NULL;
+ }
+ } else {
+ bdrv_set_dirty_bitmap(copy_bitmap, 0,
+ bdrv_dirty_bitmap_size(copy_bitmap));
+ }
/*
* If source is in backing chain of target assume that target is going to
be
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
index 5bdaf0a9d9..799223e3fb 100644
--- a/block/copy-before-write.c
+++ b/block/copy-before-write.c
@@ -170,7 +170,7 @@ static int cbw_open(BlockDriverState *bs, QDict *options,
int flags,
((BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP | BDRV_REQ_NO_FALLBACK) &
bs->file->bs->supported_zero_flags);
- s->bcs = block_copy_state_new(bs->file, s->target, errp);
+ s->bcs = block_copy_state_new(bs->file, s->target, NULL, errp);
if (!s->bcs) {
error_prepend(errp, "Cannot create block-copy-state: ");
return -EINVAL;
--
2.31.1
- [PATCH v5 00/16] Make image fleecing more usable, Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 05/16] block/block-copy: add block_copy_reset(), Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 01/16] block/block-copy: move copy_bitmap initialization to block_copy_state_new(), Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 04/16] block/copy-before-write: add bitmap open parameter, Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 02/16] block/dirty-bitmap: bdrv_merge_dirty_bitmap(): add return value, Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 06/16] block: intoduce reqlist, Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 07/16] block/reqlist: reqlist_find_conflict(): use ranges_overlap(), Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 08/16] block/dirty-bitmap: introduce bdrv_dirty_bitmap_status(), Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 03/16] block/block-copy: block_copy_state_new(): add bitmap parameter,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v5 10/16] block/io: introduce block driver snapshot-access API, Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 09/16] block/reqlist: add reqlist_wait_all(), Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 11/16] block: introduce snapshot-access block driver, Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 12/16] block: copy-before-write: realize snapshot-access API, Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 13/16] iotests/image-fleecing: add test-case for fleecing format node, Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 15/16] iotests/image-fleecing: add test case with bitmap, Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 14/16] iotests.py: add qemu_io_pipe_and_status(), Vladimir Sementsov-Ogievskiy, 2022/02/28
- [PATCH v5 16/16] iotests/image-fleecing: test push backup with fleecing, Vladimir Sementsov-Ogievskiy, 2022/02/28