Re: [PATCH v2 13/18] tests/tcg: add vectorised sha512 versions

[Alex Bennée]

Alex Bennée <alex.bennee@linaro.org> writes:

> Richard Henderson <richard.henderson@linaro.org> writes:
>
>> On 2/25/22 07:20, Alex Bennée wrote:
>>> +++ b/tests/tcg/i386/Makefile.target
>>> @@ -71,3 +71,9 @@ TESTS=$(MULTIARCH_TESTS) $(I386_TESTS)
>>>     # On i386 and x86_64 Linux only supports 4k pages (large pages
>>> are a different hack)
>>>   EXTRA_RUNS+=run-test-mmap-4096
>>> +
>>> +sha512-sse: CFLAGS=-msse4.1 -O3
>>> +sha512-sse: sha512.c
>>> +   $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< -o $@ $(LDFLAGS)
>>> +
>>> +TESTS+=sha512-sse
>>
>> The default cpu, qemu32, only implements sse3, not sse4.1, so we get a
>> guest SIGILL.  We can execute this with -cpu max, or we could limit
>> the vectorization.
>
> OK I'll add:
>
> run-sha512-vector: QEMU_OPTS+=-cpu max
>
> TESTS+=sha512-sse

Or you know something that will actually work :-/

  sha512-sse: CFLAGS=-msse4.1 -O3
  sha512-sse: sha512.c
          $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< -o $@ $(LDFLAGS)

  run-sha512-sse: QEMU_OPTS+=-cpu max
  run-plugin-sha512-sse-with-%: QEMU_OPTS+=-cpu max

  TESTS+=sha512-sse

>
>>
>>
>> r~


-- 
Alex Bennée