[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 08/19] vfio-user: instantiate vfio-user context
From: |
Jag Raman |
Subject: |
Re: [PATCH v6 08/19] vfio-user: instantiate vfio-user context |
Date: |
Mon, 28 Feb 2022 19:16:18 +0000 |
> On Feb 21, 2022, at 10:42 AM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> On Thu, Feb 17, 2022 at 02:48:55AM -0500, Jagannathan Raman wrote:
>> @@ -124,6 +190,11 @@ static void vfu_object_init(Object *obj)
>>
>> k->nr_devs++;
>>
>> + if (!phase_check(PHASE_MACHINE_READY)) {
>> + o->machine_done.notify = vfu_object_machine_done;
>> + qemu_add_machine_init_done_notifier(&o->machine_done);
>
> This probably has to happen after the next if statement since
> qemu_add_machine_init_done_notifier() can immediately call ->notify()
> and we'd try to initialize on a non-remote machine type.
OK, got it.
Thank you!
--
Jag
- [PATCH v6 02/19] tests/avocado: Specify target VM argument to helper routines, (continued)
- [PATCH v6 02/19] tests/avocado: Specify target VM argument to helper routines, Jagannathan Raman, 2022/02/17
- [PATCH v6 04/19] remote/machine: add HotplugHandler for remote machine, Jagannathan Raman, 2022/02/17
- [PATCH v6 06/19] vfio-user: build library, Jagannathan Raman, 2022/02/17
- [PATCH v6 10/19] vfio-user: run vfio-user context, Jagannathan Raman, 2022/02/17
- [PATCH v6 08/19] vfio-user: instantiate vfio-user context, Jagannathan Raman, 2022/02/17
- [PATCH v6 12/19] vfio-user: IOMMU support for remote device, Jagannathan Raman, 2022/02/17
- [PATCH v6 09/19] vfio-user: find and init PCI device, Jagannathan Raman, 2022/02/17
- [PATCH v6 01/19] configure, meson: override C compiler for cmake, Jagannathan Raman, 2022/02/17