[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/14] hw/ppc/spapr_caps.c: use g_autofree in spapr_caps_add_
From: |
David Gibson |
Subject: |
Re: [PATCH 05/14] hw/ppc/spapr_caps.c: use g_autofree in spapr_caps_add_properties() |
Date: |
Tue, 1 Mar 2022 14:15:59 +1100 |
On Mon, Feb 28, 2022 at 02:49:55PM -0300, Daniel Henrique Barboza wrote:
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/ppc/spapr_caps.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c
> index 2773f9db9e..655ab856a0 100644
> --- a/hw/ppc/spapr_caps.c
> +++ b/hw/ppc/spapr_caps.c
> @@ -930,16 +930,13 @@ void spapr_caps_add_properties(SpaprMachineClass *smc)
>
> for (i = 0; i < ARRAY_SIZE(capability_table); i++) {
> SpaprCapabilityInfo *cap = &capability_table[i];
> - char *name = g_strdup_printf("cap-%s", cap->name);
> - char *desc;
> + g_autofree char *name = g_strdup_printf("cap-%s", cap->name);
> + g_autofree char *desc = g_strdup_printf("%s", cap->description);
>
> object_class_property_add(klass, name, cap->type,
> cap->get, cap->set,
> NULL, cap);
>
> - desc = g_strdup_printf("%s", cap->description);
> object_class_property_set_description(klass, name, desc);
> - g_free(name);
> - g_free(desc);
> }
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH 01/14] hw/ppc/spapr.c: use g_autofree in spapr_dt_chosen(), (continued)
- [PATCH 01/14] hw/ppc/spapr.c: use g_autofree in spapr_dt_chosen(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 03/14] hw/ppc/spapr_caps.c: use g_autofree in spapr_cap_set_string(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 02/14] hw/ppc/spapr.c: fail early if no firmware found in machine_init(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 04/14] hw/ppc/spapr_caps.c: use g_autofree in spapr_cap_get_string(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 05/14] hw/ppc/spapr_caps.c: use g_autofree in spapr_caps_add_properties(), Daniel Henrique Barboza, 2022/02/28
- Re: [PATCH 05/14] hw/ppc/spapr_caps.c: use g_autofree in spapr_caps_add_properties(),
David Gibson <=
- [PATCH 06/14] hw/ppc/spapr_drc.c: use g_auto in spapr_dt_drc(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 07/14] hw/ppc/spapr_drc.c: use g_autofree in drc_realize(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 08/14] hw/ppc/spapr_drc.c: use g_autofree in drc_unrealize(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 09/14] hw/ppc/spapr_drc.c: use g_autofree in spapr_dr_connector_new(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 10/14] hw/ppc/spapr_drc.c: use g_autofree in spapr_drc_by_index(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 14/14] hw/ppc/spapr_vio.c: use g_autofree in spapr_dt_vdevice(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 13/14] hw/ppc/spapr_rtas.c: use g_autofree in rtas_ibm_get_system_parameter(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 12/14] spapr_pci_nvlink2.c: use g_autofree in spapr_phb_nvgpu_ram_populate_dt(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 11/14] hw/ppc/spapr_numa.c: simplify spapr_numa_write_assoc_lookup_arrays(), Daniel Henrique Barboza, 2022/02/28
- Re: [PATCH 00/14] simple cleanups in spapr files, Philippe Mathieu-Daudé, 2022/02/28