Re: [PATCH] ppc/pnv: fix default PHB4 QOM hierarchy

[Cédric Le Goater]

On 2/28/22 14:51, Daniel Henrique Barboza wrote:
> On 2/26/22 10:49, Cédric Le Goater wrote:
> > On 2/18/22 21:28, Daniel Henrique Barboza wrote:
> > > Commit 3f4c369ea63e ("ppc/pnv: make PECs create and realize PHB4s")
> > > changed phb4_pec code to create the default PHB4 objects in
> > > pnv_pec_default_phb_realize(). In this process the stacks[] PEC array was
> > > removed and each PHB4 object is tied together with its PEC via the
> > > phb->pec pointer.
> > >
> > > This change also broke the previous QOM hierarchy - the PHB4 objects are
> > > being created and not being parented to their respective chips. This can
> > > be verified by 'info pic' in a powernv9 domain with default settings.
> > > pnv_chip_power9_pic_print_info() will fail to find the PHBs because
> > > object_child_foreach_recursive() won't find any.
> > >
> > > The solution is to set the parent chip and the parent bus, in the same
> > > way done for user created PHB4 devices, for all PHB4 devices.
> > >
> > > Fixes: 3f4c369ea63e ("ppc/pnv: make PECs create and realize PHB4s")
> > > Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> >
> >
> > What about the pnv-phb3/4-root-port devices ? Should we attached
> > them also to the QOM hierarchy ?
>
>
> I guess it wouldn't hurt. I'll see what I can do.

I took it as it is for ppc-7.0. Changes can come after. Nothing critical.

Thanks,

C.