[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 23/25] migration: Fail postcopy preempt with TLS for now
From: |
Peter Xu |
Subject: |
[PATCH v2 23/25] migration: Fail postcopy preempt with TLS for now |
Date: |
Tue, 1 Mar 2022 16:39:23 +0800 |
The support is not yet there. Temporarily fail it properly when starting
postcopy until it's supported. Fail at postcopy-start still allows the
user to proceed with e.g. pure tls precopy even if postcopy-ram is set.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/migration.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index f30bad982c..95cfc483c9 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1802,6 +1802,12 @@ void qmp_migrate_start_postcopy(Error **errp)
" started");
return;
}
+
+ if (migrate_postcopy_preempt() && migrate_tls_enabled()) {
+ error_setg(errp, "Postcopy preemption does not support TLS yet");
+ return;
+ }
+
/*
* we don't error if migration has finished since that would be racy
* with issuing this command.
--
2.32.0
- [PATCH v2 14/25] migration: Add migration_incoming_transport_cleanup(), (continued)
- [PATCH v2 14/25] migration: Add migration_incoming_transport_cleanup(), Peter Xu, 2022/03/01
- [PATCH v2 15/25] migration: Allow migrate-recover to run multiple times, Peter Xu, 2022/03/01
- [PATCH v2 13/25] migration: Move channel setup out of postcopy_try_recover(), Peter Xu, 2022/03/01
- [PATCH v2 16/25] migration: Add postcopy-preempt capability, Peter Xu, 2022/03/01
- [PATCH v2 17/25] migration: Postcopy preemption preparation on channel creation, Peter Xu, 2022/03/01
- [PATCH v2 18/25] migration: Postcopy preemption enablement, Peter Xu, 2022/03/01
- [PATCH v2 19/25] migration: Postcopy recover with preempt enabled, Peter Xu, 2022/03/01
- [PATCH v2 12/25] migration: Export ram_load_postcopy(), Peter Xu, 2022/03/01
- [PATCH v2 21/25] migration: Parameter x-postcopy-preempt-break-huge, Peter Xu, 2022/03/01
- [PATCH v2 22/25] migration: Add helpers to detect TLS capability, Peter Xu, 2022/03/01
- [PATCH v2 23/25] migration: Fail postcopy preempt with TLS for now,
Peter Xu <=
- [PATCH v2 20/25] migration: Create the postcopy preempt channel asynchronously, Peter Xu, 2022/03/01
- [PATCH v2 25/25] tests: Pass in MigrateStart** into test_migrate_start(), Peter Xu, 2022/03/01
- [PATCH v2 24/25] tests: Add postcopy preempt test, Peter Xu, 2022/03/01
- Re: [PATCH v2 00/25] migration: Postcopy Preemption, Daniel P . Berrangé, 2022/03/01