[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 20/20] tests: Add postcopy preempt test
From: |
Peter Xu |
Subject: |
Re: [PATCH 20/20] tests: Add postcopy preempt test |
Date: |
Wed, 2 Mar 2022 14:41:44 +0800 |
On Tue, Mar 01, 2022 at 05:00:15PM +0000, Dr. David Alan Gilbert wrote:
> > That's tricky, and we could have done something better.. E.g., we could
> > pass in the MigrateStart** into test_migrate_start() so it can clear it
> > when free, that's not silent use-after-free but crashing, which is better
> > in this case.
> >
> > I feel lucky I tried..
>
> It could at least do with a comment on test_migrate_start?
I've added one more patch there at the end of v2 for this:
[PATCH v2 25/25] tests: Pass in MigrateStart** into test_migrate_start()
Although it's at the end of the series, it can still be cleanly applied to
current master branch, too.
Thanks,
--
Peter Xu